Skip to content

Update matrix-sdk-crypto-wasm to 11.0.0#4566

Merged
uhoreg merged 4 commits intomatrix-org:developfrom
uhoreg:crypto-wasm-11
Dec 9, 2024
Merged

Update matrix-sdk-crypto-wasm to 11.0.0#4566
uhoreg merged 4 commits intomatrix-org:developfrom
uhoreg:crypto-wasm-11

Conversation

@uhoreg
Copy link
Copy Markdown
Member

@uhoreg uhoreg commented Nov 28, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@uhoreg uhoreg added T-Task Tasks for the team like planning Dependencies Pull requests that update a dependency file labels Nov 28, 2024
@uhoreg uhoreg marked this pull request as ready for review November 28, 2024 20:52
@uhoreg uhoreg requested review from a team as code owners November 28, 2024 20:52
@uhoreg uhoreg mentioned this pull request Nov 28, 2024
Closed
1 task
andybalaam
andybalaam approved these changes Nov 29, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, tough work.

@langleyd langleyd removed their request for review November 29, 2024 10:06
dbkr
dbkr reviewed Nov 29, 2024
View reviewed changes
Comment thread spec/integ/crypto/verification.spec.ts Outdated
@richvdh richvdh removed their request for review November 29, 2024 11:02
@uhoreg uhoreg requested a review from dbkr December 2, 2024 21:14
richvdh
richvdh reviewed Dec 3, 2024
View reviewed changes
Comment thread spec/integ/crypto/verification.spec.ts Outdated
richvdh
richvdh requested changes Dec 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

richvdh
richvdh reviewed Dec 3, 2024
View reviewed changes
Comment thread spec/integ/crypto/verification.spec.ts Outdated
Comment thread spec/integ/crypto/verification.spec.ts Outdated
@uhoreg uhoreg requested a review from richvdh December 3, 2024 23:03
richvdh
richvdh approved these changes Dec 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@richvdh richvdh added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@richvdh richvdh added this pull request to the merge queue Dec 4, 2024
@richvdh
Copy link
Copy Markdown
Member

richvdh commented Dec 4, 2024

Test flake tracked at element-hq/element-web#28634

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@richvdh
Copy link
Copy Markdown
Member

richvdh commented Dec 4, 2024

Turns out it's not a flake. Sorry @uhoreg, looks like you have more work to do here

@uhoreg uhoreg mentioned this pull request Dec 5, 2024
Merged
4 tasks
@uhoreg
Copy link
Copy Markdown
Member Author

uhoreg commented Dec 6, 2024

Going to try adding to the merge queue again, and see if I was just really unlucky with the complement-crypto test. The CI will still fail due to the playwright test.

@uhoreg uhoreg added this pull request to the merge queue Dec 6, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 6, 2024
@uhoreg
Copy link
Copy Markdown
Member Author

uhoreg commented Dec 6, 2024

Complement crypto succeeded this time, so it is flaky. element-hq/element-web#28668 will fix the playwright test

@uhoreg uhoreg added this pull request to the merge queue Dec 9, 2024
Merged via the queue into matrix-org:develop with commit ded8729 Dec 9, 2024
@uhoreg uhoreg deleted the crypto-wasm-11 branch December 9, 2024 23:27
@uhoreg uhoreg mentioned this pull request Dec 10, 2024
Open
@richvdh
Copy link
Copy Markdown
Member

richvdh commented Dec 18, 2024

Everyone (including myself): please can we not mark matrix-sdk-crypto-wasm upgrades as T-Task, so that they wind up in the changelog?

@t3chguy
Copy link
Copy Markdown
Member

t3chguy commented Dec 18, 2024

Everyone (including myself): please can we not mark matrix-sdk-crypto-wasm upgrades as T-Task, so that they wind up in the changelog?

Might want to exclude it from renovate then as that sets the label to task too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andybalaam andybalaam andybalaam approved these changes

@dbkr dbkr dbkr approved these changes

@richvdh richvdh richvdh approved these changes

Assignees

No one assigned

Labels

Dependencies Pull requests that update a dependency file T-Task Tasks for the team like planning

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@uhoreg @richvdh @t3chguy @andybalaam @dbkr
⚡